Fix equals implementation in KGP shims.

touchlab · May 21, 2024 · 45a35b9 · 45a35b9
1 parent a2aa9ab
commit 45a35b9
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 8 deletions.
diff --git a/...src/kgp_common/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKonanTargetShim.kt b/...src/kgp_common/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKonanTargetShim.kt
@@ -14,8 +14,14 @@ class ActualKonanTargetShim(
     override fun toString(): String =
         konanTarget.toString()
 
-    override fun equals(other: Any?): Boolean =
-        konanTarget == other
+    override fun equals(other: Any?): Boolean {
+        if (this === other) return true
+        if (other !is ActualKonanTargetShim) return false
+
+        if (konanTarget != other.konanTarget) return false
+
+        return true
+    }
 
     override fun hashCode(): Int =
         konanTarget.hashCode()

diff --git a/...on/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKotlinNativeCompilationShim.kt b/...on/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKotlinNativeCompilationShim.kt
@@ -35,8 +35,14 @@ class ActualKotlinNativeCompilationShim(
     override fun toString(): String =
         kotlinNativeCompilation.toString()
 
-    override fun equals(other: Any?): Boolean =
-        kotlinNativeCompilation == other
+    override fun equals(other: Any?): Boolean {
+        if (this === other) return true
+        if (other !is ActualKotlinNativeCompilationShim) return false
+
+        if (kotlinNativeCompilation != other.kotlinNativeCompilation) return false
+
+        return true
+    }
 
     override fun hashCode(): Int =
         kotlinNativeCompilation.hashCode()

diff --git a/..._common/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKotlinNativeTargetShim.kt b/..._common/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKotlinNativeTargetShim.kt
@@ -24,8 +24,14 @@ class ActualKotlinNativeTargetShim(
     override fun toString(): String =
         kotlinNativeTarget.toString()
 
-    override fun equals(other: Any?): Boolean =
-        kotlinNativeTarget == other
+    override fun equals(other: Any?): Boolean {
+        if (this === other) return true
+        if (other !is ActualKotlinNativeTargetShim) return false
+
+        if (kotlinNativeTarget != other.kotlinNativeTarget) return false
+
+        return true
+    }
 
     override fun hashCode(): Int =
         kotlinNativeTarget.hashCode()

diff --git a/...kgp_common/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKotlinSourceSetShim.kt b/...kgp_common/gradle_common/kotlin/co/touchlab/skie/plugin/shim/ActualKotlinSourceSetShim.kt
@@ -15,8 +15,14 @@ class ActualKotlinSourceSetShim(
     override fun toString(): String =
         kotlinSourceSet.toString()
 
-    override fun equals(other: Any?): Boolean =
-        kotlinSourceSet == other
+    override fun equals(other: Any?): Boolean {
+        if (this === other) return true
+        if (other !is ActualKotlinSourceSetShim) return false
+
+        if (kotlinSourceSet != other.kotlinSourceSet) return false
+
+        return true
+    }
 
     override fun hashCode(): Int =
         kotlinSourceSet.hashCode()