Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenses to build.edn #28

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Add licenses to build.edn #28

merged 2 commits into from
Jul 23, 2024

Conversation

makinoshi
Copy link
Member

No description provided.

@makinoshi makinoshi marked this pull request as ready for review July 23, 2024 01:07
@makinoshi makinoshi requested a review from liquidz July 23, 2024 01:07
Copy link
Member

@liquidz liquidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makinoshi Sorry I didn't point this out first 🙇

build.edn Outdated
@@ -1,6 +1,8 @@
{:lib toyokumo/toyokumo-commons
:version "0.3.{{git/commit-count}}"
:description "Utility functions that are used in multiple Toyokumo products"
:licenses [{:name "Apache License Version 2.0,"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT The name does not have to be exact, so it is NIT, but there is a comma at the end.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 38b35a3 😃

Copy link
Member

@liquidz liquidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makinoshi Thanks! LGTM

@makinoshi makinoshi merged commit 53a4e81 into main Jul 23, 2024
1 check passed
@makinoshi makinoshi deleted the add-licenses-to-build-edn branch July 23, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants