Cleanup and fixes

Model/ApiFacade/OpenApi.php

@@ -15,17 +15,17 @@ public function create(array $data): array
         return $this->updateRedirectUrl($transaction);
     }
 
-    public function createWithInstantRedirect(array $data)
+    public function createWithInstantRedirect(array $data): array
     {
         $transactionData = $this->handleDataStructure($data);
         $transaction = $this->transactions()->createTransactionWithInstantRedirection($transactionData);
 
         return $this->updateRedirectUrl($transaction);
     }
 
-    public function makeRefund(InfoInterface $payment, string $amount): array
+    public function makeRefund(InfoInterface $payment, float $amount): array
     {
-        return $this->Transactions->createRefundByTransactionId(['amount' => number_format($amount, 2)], $payment->getAdditionalInformation('transaction_id'));
+        return $this->transactions()->createRefundByTransactionId(['amount' => $amount], $payment->getAdditionalInformation('transaction_id'));
     }
 
     public function channels(): array

Model/ApiFacade/TpayConfig/ConfigFacade.php

@@ -17,14 +17,9 @@ class ConfigFacade
 
     /** @var bool */
     private $useOpenApi;
-    /**
-     * @var TpayInterface
-     */
-    private $tpay;
 
     public function __construct(TpayInterface $tpay, Repository $assetRepository, TpayTokensService $tokensService)
     {
-        $this->tpay = $tpay;
         $this->originApi = new ConfigOrigin($tpay, $assetRepository, $tokensService);
         $this->createOpenApiInstance($tpay, $assetRepository, $tokensService);
     }

Model/ApiFacade/Transaction/TransactionApiFacade.php

@@ -32,17 +32,17 @@ public function __construct(TpayInterface $tpay, CacheInterface $cache)
         $this->cache = $cache;
     }
 
-    public function isOpenApiUse()
+    public function isOpenApiUse(): bool
     {
         return $this->useOpenApi;
     }
 
-    public function create(array $config)
+    public function create(array $config): array
     {
         return $this->getCurrentApi()->create($config);
     }
 
-    public function createWithInstantRedirection(array $config)
+    public function createWithInstantRedirection(array $config): array
     {
         if (!$this->useOpenApi) {
             throw new TpayException('OpenAPI not availabile - Failed to create transaction with instant redirection');
@@ -51,7 +51,7 @@ public function createWithInstantRedirection(array $config)
         return $this->openApi->createWithInstantRedirect($config);
     }
 
-    public function blik($blikTransactionId, $blikCode)
+    public function blik($blikTransactionId, $blikCode): array
     {
         return $this->originApi->blik($blikTransactionId, $blikCode);
     }
@@ -72,7 +72,7 @@ public function channels(): array
             return $channel['available'] === true && empty($channel['constraints']) === true;
         });
 
-        $this->cache->save(json_encode($channels), self::CHANNELS_CACHE_KEY, []);
+        $this->cache->save(json_encode($channels), self::CHANNELS_CACHE_KEY, [], self::CACHE_LIFETIME);
 
         return $channels;
     }