SAST Changes

tpay-com · Jun 26, 2024 · 9b715b2 · 9b715b2
1 parent 36e668b
commit 9b715b2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/Model/ApiFacade/TpayConfig/ConfigOpen.php b/Model/ApiFacade/TpayConfig/ConfigOpen.php
@@ -67,13 +67,15 @@ public function showChannels(): ?string
 
     public function createScript(string $script): string
     {
-        return "
-            <script type=\"text/javascript\">
+        return <<<EOD
+
+            <script type="text/javascript">
                 require(['jquery'], function ($) {
                     $.getScript('{$this->generateURL($script)}');
 
                 });
-            </script>";
+            </script>
+EOD;
     }
 
     public function getTerms(): ?string

diff --git a/Model/ApiFacade/TpayConfig/ConfigOrigin.php b/Model/ApiFacade/TpayConfig/ConfigOrigin.php
@@ -68,13 +68,15 @@ public function showChannels(): ?string
 
     public function createScript(string $script): string
     {
-        return "
-            <script type=\"text/javascript\">
+        return <<<EOD
+
+            <script type="text/javascript">
                 require(['jquery'], function ($) {
                     $.getScript('{$this->generateURL($script)}');
 
                 });
-            </script>";
+            </script>
+EOD;
     }
 
     public function getTerms(): ?string

diff --git a/Model/ApiFacade/Transaction/TransactionApiFacade.php b/Model/ApiFacade/Transaction/TransactionApiFacade.php
@@ -12,7 +12,7 @@
 class TransactionApiFacade
 {
     private const CHANNELS_CACHE_KEY = 'tpay_channels';
-    private const CACHE_LIFETIME = 86400;
+    private const CACHE_LIFETIME = 86_400;
 
     /** @var TransactionOriginApi */
     private $originApi;