Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mu: Fill in missing TPMU variants #2621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fergus-dall
Copy link

@fergus-dall fergus-dall commented May 28, 2023

This introduces support (at the marshal/unmarshal level) for:

  • the SHA3 family of hash algorithms
  • the SHAKE256-derived family of hash algorithms
  • SHA256/192
  • the EDDSA and EDDSA_PH signing schemes, used by curve25519 and curve448
  • the tag TPM_ST_ATTEST_NV_DIGEST, for the new form of TPM2_NV_Certify
    that certifies a hash of the NV area
  • the legacy block cipher 3DES
  • the key derivation function KDF2

This also pulls in constants from the algorithm registry up to
revision 01.33, except for the new hash-based signature schemes,
TPM2_ALG_LMS and TPM2_ALG_XMSS, as these don't yet have defined
structs for their scheme parameters and signatures.

@fergus-dall fergus-dall force-pushed the tdes-fix branch 2 times, most recently from 00c9a20 to 92a3e24 Compare May 29, 2023 21:23
This introduces support (at the marshal/unmarshal level) for:
 - the SHA3 family of hash algorithms
 - the SHAKE256-derived family of hash algorithms
 - SHA256/192
 - the EDDSA and EDDSA_PH signing schemes, used by curve25519 and curve448
 - the tag TPM_ST_ATTEST_NV_DIGEST, for the new form of TPM2_NV_Certify
   that certifies a hash of the NV area
 - the legacy block cipher 3DES
 - the key derivation function KDF2

This also pulls in constants from the algorithm registry up to
revision 01.33, except for the new hash-based signature schemes,
TPM2_ALG_LMS and TPM2_ALG_XMSS, as these don't yet have defined
structs for their scheme parameters and signatures.

Signed-off-by: Fergus Dall <sidereal@google.com>
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #2621 (92a3e24) into master (8699ab3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 92a3e24 differs from pull request most recent head e03f279. Consider uploading reports for the commit e03f279 to get more accurate results

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
- Coverage   82.55%   82.54%   -0.01%     
==========================================
  Files         366      366              
  Lines       42475    42487      +12     
==========================================
+ Hits        35064    35070       +6     
- Misses       7411     7417       +6     
Impacted Files Coverage Δ
src/tss2-mu/tpmu-types.c 66.37% <0.00%> (-7.66%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AndreasFuchsTPM AndreasFuchsTPM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since none of these functions are used from any of the existing code, we should definitively add unit tests for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants