Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CL-1406: Removing full_name from symbol #111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CL-1406: Removing full_name from symbol #111

wants to merge 3 commits into from

Conversation

romfrancois
Copy link
Contributor

Following work on CL-1851, this PR updates the tutorial to not depend on full_name from an external point of view.

Not to be merged before releasing v28.

illetid
illetid approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@illetid illetid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romfrancois romfrancois requested a review from illetid May 15, 2024 13:04
@romfrancois
Copy link
Contributor Author

Have added a recommended property ticker to the returned object.

@romfrancois
Copy link
Contributor Author

@illetid could I ask for another review please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatPierce KatPierce KatPierce left review comments

@illetid illetid illetid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romfrancois @illetid @KatPierce