-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLL-303: Assert that open, close, high, low, value can safely represe… #1774
CLL-303: Assert that open, close, high, low, value can safely represe… #1774
Conversation
…nt 2 digits after the decimal point. Currently it is between -90071992547409.91 to 90071992547409.91 or ~9 quadrillion.
size-limit report 📦
|
I've also changed |
CLL-303: Fix typo SAVE/SAFE Co-authored-by: Edward Dewhurst <edward@dewhurst.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've fixed SAVE/SAFE in other places straight after the first commit, but pushed just now.
Type of PR: Improvement
Overview of change:
This PR adds validation for values in time series to prevent issue with browser freezing.
Browser freezing happens when price value cannot be safely represented as decimal with 2 digits after the dot.
#1500 occurs when the price values for the data are very very large. This PR does not fix the issue but will rather display a warning while you are using the library in 'development' mode.