Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLL-303: Assert that open, close, high, low, value can safely represe… #1774

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

signatenkov
Copy link
Contributor

@signatenkov signatenkov commented Jan 15, 2025

Type of PR: Improvement

Overview of change:

This PR adds validation for values in time series to prevent issue with browser freezing.
Browser freezing happens when price value cannot be safely represented as decimal with 2 digits after the dot.

#1500 occurs when the price values for the data are very very large. This PR does not fix the issue but will rather display a warning while you are using the library in 'development' mode.

…nt 2 digits after the decimal point. Currently it is between -90071992547409.91 to 90071992547409.91 or ~9 quadrillion.
Copy link

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size
ESM 44.8 KB (0%)
ESM createChart 36.79 KB (0%)
ESM createChartEx 35.52 KB (0%)
ESM createYieldCurveChart 36.99 KB (0%)
ESM createOptionsChart 35.74 KB (0%)
Standalone-ESM 46.3 KB (0%)
Standalone 46.21 KB (0%)
Plugin: Text Watermark 1.87 KB (0%)
Plugin: Image Watermark 1.69 KB (0%)
Plugin: Series Markers 3.98 KB (0%)
Series: LineSeries 2.54 KB (0%)
Series: BaselineSeries 3.2 KB (0%)
Series: AreaSeries 3.12 KB (0%)
Series: BarSeries 2.15 KB (0%)
Series: CandlestickSeries 2.42 KB (0%)
Series: HistogramSeries 2.18 KB (0%)
Plugin: UpDownMarkersPrimitive 2.37 KB (0%)

@signatenkov signatenkov marked this pull request as ready for review January 15, 2025 15:18
.size-limit.js Outdated Show resolved Hide resolved
.size-limit.js Outdated Show resolved Hide resolved
src/model/data-validators.ts Show resolved Hide resolved
@signatenkov
Copy link
Contributor Author

I've also changed npm run size-limit a bit so it now highlights when bundle is less than a limit + it would build prod automatically in case if there is none or after changing a branch

package.json Outdated Show resolved Hide resolved
src/model/data-validators.ts Outdated Show resolved Hide resolved
signatenkov and others added 2 commits January 16, 2025 14:55
CLL-303: Fix typo SAVE/SAFE

Co-authored-by: Edward Dewhurst <edward@dewhurst.io>
@tradingview tradingview deleted a comment from SlicedSilver Jan 16, 2025
@tradingview tradingview deleted a comment from SlicedSilver Jan 16, 2025
Copy link
Contributor Author

@signatenkov signatenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've fixed SAVE/SAFE in other places straight after the first commit, but pushed just now.

@signatenkov signatenkov merged commit 56031e7 into v5-candidate Jan 16, 2025
33 checks passed
@signatenkov signatenkov deleted the CLL-303_validate_price_for_precision_error branch January 16, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants