Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes from PR #40 aren't reflected in the live GitBook #51

Open
felipewarrener opened this issue Apr 19, 2019 · 3 comments
Open

Changes from PR #40 aren't reflected in the live GitBook #51

felipewarrener opened this issue Apr 19, 2019 · 3 comments

Comments

@felipewarrener
Copy link

Pull request #40 supposedly fixes broken links, but this change isn't reflected in the web-facing version.
@dguido
Copy link
Member

dguido commented Apr 19, 2019

Github pages is on a separate branch, and someone needs to go and update that one after the PR gets accepted to master.

@felipewarrener
Copy link
Author

The PR has been merged for 2 years, how does someone view and update the public branch? It's not something I can find myself? @dguido

@dguido
Copy link
Member

dguido commented Apr 20, 2019

Ah, it looks like the process improved a little bit since I last looked at it. You need to compile the gitbook and output the HTML to the /docs/ directory. Check out the installation instructions here: https://github.com/GitbookIO/gitbook/blob/master/docs/setup.md

@crd477 crd477 mentioned this issue Jul 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dguido @felipewarrener