Update develop to have new changes #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For APC taxa, the scientific_name_id was the scientific_name_id for the aligned name, not the accepted_name. This was because scientific_name_id was merged in too early - it has been fixed.
* map in APNI genera We'd initially made the decision that the genus-column would remain blank if the genus wasn't APC-accepted. For AusTraits at least this is odd - as there are 100's of entries with a taxon name, scientific name, scientific name identifier, but no genus.
Fix how a "genus" is identified within a taxon name - For hybrid genera the genus name is "x genus" - this was causing problems in AusTraits, because I'd only included an ifelse to hunt for "x" in some places - As part of this fix, package `extract_genus` into its own function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.