Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cran prep #67

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Cran prep #67

merged 8 commits into from
Jul 27, 2023

Conversation

wcornwell
Copy link
Contributor

getting devtools::check() output to look nice via tricks from Jenny Bryan via Fonti (also see here: https://stackoverflow.com/questions/76242926/using-data-table-in-package-development-undefined-global-functions-or-variables)

@wcornwell wcornwell requested a review from fontikar July 27, 2023 01:51
@wcornwell
Copy link
Contributor Author

:(

@fontikar
Copy link
Collaborator

Oh dear @wcornwell failing tests :\ Not sure why R CMD check is failing at L56 in the vignette

Unsure if this is different to the test-coverage failure - do you mind investigating pls 🔍

Copy link
Collaborator

@fontikar fontikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wahoo! Squash and merge! 🎃

@wcornwell wcornwell merged commit ba81220 into master Jul 27, 2023
6 checks passed
@wcornwell wcornwell deleted the cran_prep branch July 27, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants