Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgdown upgrades with diagrams and more documentation #71

Merged
merged 9 commits into from
Jul 28, 2023
Merged

pkgdown upgrades with diagrams and more documentation #71

merged 9 commits into from
Jul 28, 2023

Conversation

fontikar
Copy link
Collaborator

@fontikar fontikar commented Jul 28, 2023 •
edited
Loading

Addresses #65

  • Vignette is prerendered for speedier testing local and on GHA
  • Customised pkgdown website with bootswatch theme
  • Customisation with articles menu
  • Inserted figures made with powerpoint in vignette and data provider article
  • Updated README to point to pkgdown

@fontikar fontikar requested a review from dfalster July 28, 2023 06:15
dfalster
dfalster reviewed Jul 28, 2023
View reviewed changes
README.Rmd Outdated Show resolved Hide resolved
dfalster
dfalster reviewed Jul 28, 2023
View reviewed changes
vignettes/ausflora.Rmd Outdated Show resolved Hide resolved
dfalster
dfalster previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Happy for you to merge once suggested minor changes are implemented

No need for additional review

@fontikar
Copy link
Collaborator Author

Oh dear, after minor correction, its triggered another review! @dfalster when you get a chance next week! :) this doesn't conflict with any other branches at the moment so no rush!

@fontikar fontikar merged commit eb95d0f into master Jul 28, 2023
6 checks passed
@fontikar fontikar deleted the website branch July 28, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfalster dfalster dfalster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fontikar @dfalster