-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create new function check_compatibility
#95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create new function to check is data object compatible with austraits 3.0 functions
add documentation, fix typo
update readme to indicate how to source older versions of austraits
add messaging, change how T/F is stored... but I'm not sure how to avoid the value of "compatible" being shown
Add utils function to convert a list of lists to a dataframe
tentative test for check_compatibility
one last test.
fontikar
reviewed
Sep 4, 2024
fontikar
reviewed
Sep 4, 2024
fontikar
reviewed
Sep 4, 2024
fontikar
reviewed
Sep 4, 2024
fontikar
reviewed
Sep 4, 2024
fontikar
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing effort, excited to build on this!! Thanks for figuring out a generalised example for the util_list_to_df2
function! Some minor changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new function to check if the data object being used with austraits functions is compatible, explicitly checking if it has been built using traits.build (vs older AusTraits versions that were built by the internal austraits.build workflow).
Includes simple tests.
Towards issue #93