Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[traits.build adding studies functions] Merge some current {austraits} functions into {traits.build} #168

Open
ehwenk opened this issue Aug 1, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@ehwenk
Copy link
Collaborator

ehwenk commented Aug 1, 2024

Merge some current {austraits} functions into {traits.build} to reduce package co-dependencies.

Need to review which functions should be moved, then move them.

@ehwenk
Copy link
Collaborator Author

ehwenk commented Aug 26, 2024

I believe the only austraits.R function used in traits.build is extract_dataset is used in report_dataset.Rmd. While we could bypass extract_dataset using filter (separately for each table), the function being developed to create a single combined table does require join_contexts.

Therefore, we need to more broadly work out a plan for which functions will be part of which package.

@ehwenk ehwenk added this to the austraits 3.0 milestone Sep 5, 2024
@ehwenk
Copy link
Collaborator Author

ehwenk commented Sep 5, 2024

We've actually decided to do the reverse and move functions back to austraits. report_dataset.Rmd will remain in traits.build, but the remaining functions, including the function to build a single combined table will move to austraits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant