Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable #65

Open
JustinShenk opened this issue Feb 7, 2021 · 1 comment
Open

Unused variable #65

JustinShenk opened this issue Feb 7, 2021 · 1 comment
Assignees
@Saran-nns
Labels
invalid This doesn't seem right

Comments

@JustinShenk
Copy link
Collaborator

traja/traja/models/visualizer.py

Line 64 in e3dcf25

self_connections = [weight[i][i] for i in range(len(weight))]

Please remove unused variable self_connections, and in the future lint before committing code.
@JustinShenk JustinShenk added the invalid This doesn't seem right label Feb 7, 2021
@Saran-nns
Copy link
Member

Yes, self connections/time-delayed connections are not used in the current latent visualization. Also, note this visualizer support only recurrent networks. At the moment, latent models in traja are feedforward. However, the encoders and decoders have LSTM layer's whose activations/connections can be visualized by passing their hidden to hidden weights to the wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saran-nns Saran-nns

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustinShenk @Saran-nns