Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reserved metadata, reorg exerience vars/types #104

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

csmccarthy
Copy link
Member

Related Issues

Internal Changelog

Most of this diff is just some reorganization of the experience vars/types/functions that Minh asked for here, the actual change are the 7 lines in core.ts which adds supports for reserved metadata within the greater metadata object. This is to be used for airgap module data storage for anything that we'd like to sync client-side, with the preference store, or send off to telemetry.

@csmccarthy csmccarthy requested a review from a team November 8, 2023 19:15
Copy link

height bot commented Nov 8, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-27112" to the pull request title or description, to a commit message, or in a comment to mark this task as "Pending Deploy" when the pull request is merged.

Copy link
Member

@anotherminh anotherminh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!

@csmccarthy csmccarthy merged commit 8dccfc6 into main Nov 8, 2023
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the csmccarthy/reserved-metadata branch November 8, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants