Add types for mobile consent config #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:
|
anotherminh
commented
Dec 7, 2023
| @@ -51,7 +51,7 @@ const RAW_RUNTIME_STATE = | |||
| ]],\ | |||
| ["@aashutoshrathi/word-wrap", [\ | |||
| ["npm:1.2.6", {\ | |||
| "packageLocation": "../../home/codespace/.yarn/berry/cache/@aashutoshrathi-word-wrap-npm-1.2.6-5b1d95e487-10c0.zip/node_modules/@aashutoshrathi/word-wrap/",\ | |||
| "packageLocation": "../../.yarn/berry/cache/@aashutoshrathi-word-wrap-npm-1.2.6-5b1d95e487-10c0.zip/node_modules/@aashutoshrathi/word-wrap/",\ | |||
There was a problem hiding this comment.
@dmattia Is this.. expected? I ran yarn and it updated all these paths
There was a problem hiding this comment.
Also, not sure why there are 2 run-mocha jobs that are ran for node 12 and 14.. in the workflow file I'm only seeing config for node 18 and 20:
airgap.js-types/.github/workflows/ci.yml
Line 25 in 563ebfd
dmattia
approved these changes
Dec 8, 2023
delete-merged-branch
bot
deleted the
anotherminh/add-mobile-consent-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Security Implications
[none]
System Availability
[none]