Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add z-index config field #99

Merged
merged 2 commits into from
Oct 10, 2023
Merged

add z-index config field #99

merged 2 commits into from
Oct 10, 2023

Conversation

csmccarthy
Copy link
Member

Related Issues

links https://transcend.height.app/T-30079

Internal Changelog

Context: Eventbrite took umbridge with the consent banner staying at the maximum z-index and blocking a payment modal of theirs

Fix: We added a new config option to allow for a manually specified z-index on the consent banner

Notes: We don't want to make this easy to enable, since in general "hiding" the consent banner like this is a bad pattern to follow. There may or may not be a better place to set this config value to better achieve that goal of making hiding sufficiently difficult (if there is, let me know)

@csmccarthy csmccarthy requested a review from a team October 6, 2023 21:50
@height
Copy link

height bot commented Oct 6, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-30079" to the pull request title or description, to a commit message, or in a comment to mark this task as "Pending Deploy" when the pull request is merged.

@csmccarthy
Copy link
Member Author

Just realized this is going to need a version bump for airgap.js-types, still need to figure out how to make a new release. That'll be a Monday thing

@csmccarthy csmccarthy marked this pull request as draft October 6, 2023 21:56
@MadDataScience
Copy link
Contributor

Just realized this is going to need a version bump for airgap.js-types, still need to figure out how to make a new release. That'll be a Monday thing

It's simple. You just need to bump the version number here:

"version": "10.6.1",

@csmccarthy csmccarthy marked this pull request as ready for review October 10, 2023 16:46
@csmccarthy csmccarthy merged commit df844c0 into main Oct 10, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the csmccarthy/z-index-config branch October 10, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants