-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More strict eslint? #90
Comments
plus prettier i'd vote, same as we've been doing for other transloadit repos 👌 |
we already have prettier here but for some reason i think it's not working properly:
|
That's on MDX files, right? I think that's because Prettier doesn't support them out of the box. |
no, also examples.tsx but I ran the "npm run format" command and it caused aws-s3.mdx to get modified by prettier: bbba0e5#diff-4c2bc38564b6cae2154e034b529fcd7788562662ff3b1121992c1d454eb8abc2 - a file that i hadn't touched |
Perhaps we can set Prettier for filetypes that work well, but Remark for mdx since as reported Prettier adds newlines in wrong places there(?) "[markdown]": {
"files.trimTrailingWhitespace": false,
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[html]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[mdx]": {
"editor.defaultFormatter": "<REMARK?>"
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"editor.formatOnSave": true, @arturi is going to show @aduh95 where it breaks for him Merlijn says we should install the MDX VS Code Extension |
I noticed that eslint doesn't complain about almost anything, e.g. semicolons vs no semicolons, and it doesn't help us with missing react hooks dependencies. should we have more strict linting? maybe transloadit rules?
The text was updated successfully, but these errors were encountered: