Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Google Picker locale entries #5552

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

Murderlon
Copy link
Member

Fixes #5542

@Murderlon Murderlon requested a review from mifi December 16, 2024 12:40
@Murderlon Murderlon self-assigned this Dec 16, 2024
Copy link
Contributor

Diff output files
diff --git a/packages/@uppy/google-drive-picker/lib/locale.js b/packages/@uppy/google-drive-picker/lib/locale.js
index 8bb07b3..b345088 100644
--- a/packages/@uppy/google-drive-picker/lib/locale.js
+++ b/packages/@uppy/google-drive-picker/lib/locale.js
@@ -1,3 +1,5 @@
 export default {
-  strings: {},
+  strings: {
+    pluginNameGoogleDrive: "Google Drive",
+  },
 };
diff --git a/packages/@uppy/google-photos-picker/lib/locale.js b/packages/@uppy/google-photos-picker/lib/locale.js
index 8bb07b3..fec03f5 100644
--- a/packages/@uppy/google-photos-picker/lib/locale.js
+++ b/packages/@uppy/google-photos-picker/lib/locale.js
@@ -1,3 +1,5 @@
 export default {
-  strings: {},
+  strings: {
+    pluginNameGooglePhotos: "Google Photos",
+  },
 };
diff --git a/packages/@uppy/locales/lib/en_US.js b/packages/@uppy/locales/lib/en_US.js
index a10ca17..73ee7bc 100644
--- a/packages/@uppy/locales/lib/en_US.js
+++ b/packages/@uppy/locales/lib/en_US.js
@@ -52,6 +52,7 @@ en_US.strings = {
   dashboardTitle: "Uppy Dashboard",
   dashboardWindowTitle: "Uppy Dashboard Window (Press escape to close)",
   dataUploadedOfTotal: "%{complete} of %{total}",
+  dataUploadedOfUnknown: "%{complete} of unknown",
   discardRecordedFile: "Discard recorded file",
   done: "Done",
   dropHereOr: "Drop here or %{browse}",
@@ -94,6 +95,7 @@ en_US.strings = {
   inferiorSize: "This file is smaller than the allowed size of %{size}",
   loadedXFiles: "Loaded %{numFiles} files",
   loading: "Loading...",
+  logIn: "Log in",
   logOut: "Log out",
   micDisabled: "Microphone access denied by user",
   missingRequiredMetaField: "Missing required meta fields",
@@ -116,6 +118,9 @@ en_US.strings = {
   pause: "Pause",
   paused: "Paused",
   pauseUpload: "Pause upload",
+  pickFiles: "Pick files",
+  pickPhotos: "Pick photos",
+  pleaseWait: "Please wait",
   pluginNameAudio: "Audio",
   pluginNameBox: "Box",
   pluginNameCamera: "Camera",

Copy link
Contributor

@mifi mifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally CI should fail if locales are missing like this. I wonder if that’s hard to do.

@Murderlon Murderlon merged commit 060734b into main Dec 16, 2024
16 checks passed
@Murderlon Murderlon deleted the google-picker-locales branch December 16, 2024 13:20
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
github-actions bot added a commit that referenced this pull request Dec 17, 2024
| Package                    | Version | Package                    | Version |
| -------------------------- | ------- | -------------------------- | ------- |
| @uppy/companion            |   5.3.0 | @uppy/progress-bar         |   4.1.0 |
| @uppy/companion-client     |   4.3.0 | @uppy/provider-views       |   4.2.0 |
| @uppy/core                 |   4.3.1 | @uppy/status-bar           |   4.0.6 |
| @uppy/google-drive-picker  |   0.2.1 | @uppy/utils                |   6.0.6 |
| @uppy/google-photos-picker |   0.2.1 | @uppy/webdav               |   0.1.0 |
| @uppy/locales              |   4.4.0 | uppy                       |   4.9.0 |

- @uppy/webdav: Add @uppy/webdav (Merlijn Vos / #5551)
- @uppy/google-drive-picker,@uppy/google-photos-picker,@uppy/locales: Add missing Google Picker locale entries (Merlijn Vos / #5552)
- @uppy/core: bring back validateRestrictions (Merlijn Vos / #5538)
- @uppy/google-drive-picker,@uppy/google-photos-picker: Fix TS generics on new Google Picker plugins (Merlijn Vos / #5550)
- @uppy/locales: Add missing French locale entries (Steven SAN / #5549)
- e2e,@uppy/status-bar,@uppy/utils: Companion stream upload unknown size files (Mikael Finstad / #5489)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: missing string: pluginNameGoogleDrive + pluginNameGooglePhotos
2 participants