Don't include patient database id in rest api output && implement rest api version number #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal database id should not be used outside of the Transmart server, the trial id (inTrialId) should be used for that. The database id is not useful anyway since it is not exported in other places so it cannot be correlated. The accompanying update in RInterface is in the patient_sets branch.
rest api needs a version number so that clients can fail gracefully if they are not compatible. There is at the moment no intention to have the server or R client support multiple versions at the same time.
|
@JanKanis can we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests failing... I'll update them.