Skip to content

Commit

Permalink
Delete unused flag
Browse files Browse the repository at this point in the history
  • Loading branch information
phbnf committed Nov 12, 2024
1 parent dcbd138 commit 8fcc48c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions cmd/conformance/gcp/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"fmt"
"io"
"net/http"
"os"
"time"

tessera "github.com/transparency-dev/trillian-tessera"
Expand All @@ -36,7 +35,6 @@ import (
var (
bucket = flag.String("bucket", "", "Bucket to use for storing log")
listen = flag.String("listen", ":2024", "Address:port to listen on")
project = flag.String("project", os.Getenv("GOOGLE_CLOUD_PROJECT"), "GCP Project, take from env if unset")
spanner = flag.String("spanner", "", "Spanner resource URI ('projects/.../...')")
signer = flag.String("signer", "", "Note signer to use to sign checkpoints")
verifier = flag.String("verifier", "", "Note verifier corresponding to --signer")
Expand Down Expand Up @@ -107,9 +105,6 @@ func main() {
// storageConfigFromFlags returns a gcp.Config struct populated with values
// provided via flags.
func storageConfigFromFlags() gcp.Config {
if *project == "" {
klog.Exit("--project flag or GOOGLE_CLOUD_PROJECT env must be set.")
}
if *bucket == "" {
klog.Exit("--bucket must be set")
}
Expand Down
1 change: 0 additions & 1 deletion deployment/modules/gcp/conformance/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ resource "google_cloud_run_v2_service" "default" {
"--v=1",
"--bucket=${module.gcs.log_bucket.id}",
"--spanner=${local.spanner_db_full}",
"--project=${var.project_id}",
"--listen=:8080",
"--signer=${var.signer}",
"--verifier=${var.verifier}",
Expand Down

0 comments on commit 8fcc48c

Please sign in to comment.