Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception for invalid env data #2

Open
svenfuchs opened this issue May 10, 2018 · 2 comments
Open

Uncaught exception for invalid env data #2

svenfuchs opened this issue May 10, 2018 · 2 comments

Comments

@svenfuchs
Copy link
Contributor

See travis-ci/travis-yml@de47ccc#commitcomment-28925719

This

Array(obj).map { |value| split(value.to_s) }.to_h
raises ArgumentError: wrong array length at 0 (expected 2, was 1) if data[:env] is an array with plain strings that do not contain =.

Should raise something like InvalidDataError instead.

@kerrizor
Copy link

I spotted this is Gatekeeper as well.

@webknjaz
Copy link

webknjaz commented May 25, 2018

@svenfuchs I think, I've spotted another regression. Old parser was able to match env-based allow_failures, new one seems to ignore env at all. Even turning it into a mapping doesn't help:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants