Confusion, re issue #585

src/bif_database.c

@@ -481,6 +481,7 @@ static bool bif_iso_asserta_1(query *q)
 		convert_to_literal(q->st.m, h);
 
 	if (!is_interned(h)) {
+		parser_destroy(p);
 		return throw_error(q, h, q->st.curr_frame, "type_error", "callable");
 	}
 
@@ -544,6 +545,7 @@ static bool bif_iso_assertz_1(query *q)
 		convert_to_literal(q->st.m, h);
 
 	if (!is_interned(h)) {
+		parser_destroy(p);
 		return throw_error(q, h, q->st.curr_frame, "type_error", "callable");
 	}
 
@@ -714,6 +716,7 @@ static bool do_assertz_2(query *q)
 		convert_to_literal(q->st.m, h);
 
 	if (!is_interned(h)) {
+		parser_destroy(p);
 		return throw_error(q, h, q->latest_ctx, "type_error", "callable");
 	}
 

src/module.c

@@ -1071,6 +1071,7 @@ void convert_to_literal(module *m, cell *c)
 	c->val_off = off;
 	c->match = NULL;
 	c->flags = 0;
+	c->arity = 0;
 	free(src);
 }
 
@@ -1598,6 +1599,14 @@ static rule *assert_begin(module *m, unsigned nbr_vars, cell *p1, bool consultin
 	if (!is_check_directive(c)) {
 		c = get_head(p1);
 
+#if 0
+		if (is_string(c)) {
+			if (consulting)
+				fprintf(stdout, "Error: not callable %s:(%s)/%u\n", m->name, C_STR(m, c), c->arity);
+			return NULL;
+		}
+#endif
+
 		if ((c->val_off == g_neck_s) && (c->arity == 1)) {
 			if (consulting)
 				fprintf(stdout, "Error: permission error modifying %s:(%s)/%u\n", m->name, C_STR(m, c), c->arity);