Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrongly formatted README #132

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Fix wrongly formatted README #132

merged 3 commits into from
Jun 5, 2024

Conversation

tung-vu-td
Copy link
Contributor

@tung-vu-td tung-vu-td commented Jun 4, 2024 •
edited
Loading

CI release job is failing because of wrongly formatted README

This PR is to:

  • Fix the format issue in README
  • Add a CI job to check the distribution build to prevent future regression regarding package publishing early

@tung-vu-td tung-vu-td changed the title Wrongly formatted readme Fix wrongly formatted README Jun 4, 2024
kietdo360
kietdo360 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@kietdo360 kietdo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kietdo360 kietdo360 requested a review from a team June 4, 2024 11:35
nmpennypacker
nmpennypacker approved these changes Jun 4, 2024
View reviewed changes
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

@tung-vu-td tung-vu-td merged commit a9fe301 into master Jun 5, 2024
23 checks passed
@tung-vu-td tung-vu-td deleted the wrongly-formatted-README branch June 5, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmpennypacker nmpennypacker nmpennypacker approved these changes

@kietdo360 kietdo360 kietdo360 approved these changes

@imnutz imnutz Awaiting requested review from imnutz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tung-vu-td @nmpennypacker @kietdo360