Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrongly formatted README #132

Merged
merged 3 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,23 @@ jobs:
env:
TD_API_KEY: 1/XXX
TD_API_SERVER: https://api.treasure-data.com/

dist-dry-run:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Set up Python
uses: actions/setup-python@v1
with:
python-version: '3.x'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install setuptools wheel twine
- name: Build and check dist for PiPY (a.k.a dry run)
run: |
python setup.py sdist bdist_wheel
twine check dist/*

24 changes: 12 additions & 12 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -131,19 +131,19 @@ data to Treasure Data:

Characteristics of each of these methods can be summarized as follows:

+-----------------------------------+------------------+------------------+-----------+
+-----------------------------------+------------------+------------------+---------------------------------+
| | ``bulk_import`` | ``insert_into`` | ``spark (No longer available)`` |
+===================================+==================+==================+===========+
| Scalable against data volume | ✓ | | |
+-----------------------------------+------------------+------------------+-----------+
| Write performance for larger data | | | |
+-----------------------------------+------------------+------------------+-----------+
| Memory efficient | ✓ | ✓ | |
+-----------------------------------+------------------+------------------+-----------+
| Disk efficient | | ✓ | |
+-----------------------------------+------------------+------------------+-----------+
| Minimal package dependency | ✓ | ✓ | |
+-----------------------------------+------------------+------------------+-----------+
+===================================+==================+==================+=================================+
| Scalable against data volume | ✓ | | |
+-----------------------------------+------------------+------------------+---------------------------------+
| Write performance for larger data | | | |
+-----------------------------------+------------------+------------------+---------------------------------+
| Memory efficient | ✓ | ✓ | |
+-----------------------------------+------------------+------------------+---------------------------------+
| Disk efficient | | ✓ | |
+-----------------------------------+------------------+------------------+---------------------------------+
| Minimal package dependency | ✓ | ✓ | |
+-----------------------------------+------------------+------------------+---------------------------------+

Enabling Spark Writer
^^^^^^^^^^^^^^^^^^^^^
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ license = Apache License 2.0
license_files =
LICENSE
long_description = file: README.rst
long_description_content_type = text/x-rst
url = https://github.com/treasure-data/pytd
classifiers =
Development Status :: 5 - Production/Stable
Expand Down
Loading