Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11. Remove support for Python 3.7 #133

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

tung-vu-td
Copy link
Contributor

Purpose

We want to add support for python 3.11, while remove support for python 3.7 due to end-of-life status

Overview

  • Run CI test for python 3.11
  • Drop CI test for 3.7
  • Update setup.cfg to reflect added support for 3.11 and remove support for 3.7


[options]
packages = find:
python_requires = >=3.7,<3.11
python_requires = >=3.7,<3.12
install_requires =
urllib3~=1.26,>=1.21.1
Copy link
Member

@chezou chezou Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this urllib3 limitation was introduced many years ago when pip had limited capability to resolve version conflicts. #14

I think we are okay to remove the version constraints, i.e., ~=1.26,>=1.21.1, (with some manual tests) since pip can resolve to choose the right version of urllib3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chezou! I created ticket to track this! Kindly continue with the review 🙇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your consideration.

Considering the current pip capability, giving a strict upper version requires frequent release; otherwise, pytd triggers version conflicts too often. Maybe preventing major upgrades for pandas and numpy would be reasonable now.

Copy link
Contributor

@imnutz imnutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kietdo360 kietdo360 requested a review from a team August 19, 2024 22:42
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

@tung-vu-td tung-vu-td merged commit cce1fdf into master Aug 26, 2024
21 checks passed
@tung-vu-td tung-vu-td deleted the support-3-11 branch August 26, 2024 09:23

[options]
packages = find:
python_requires = >=3.7,<3.11
python_requires = >=3.7,<3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally overlooked it, but it should be

python_requires = >=3.8,<3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants