Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.11. Remove support for Python 3.7 #133

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add support for Python 3.11. Remove support for Python 3.7 #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,9 @@ jobs:
max-parallel: 2
matrix:
os: [ubuntu-latest, windows-latest]
python-version: ["3.7", "3.8", "3.9", "3.10"]
pandas-version: ["1.2.5", "1.3.5", "1.4.4", "1.5.2"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
pandas-version: ["1.3.5", "1.4.4", "1.5.3"]
exclude:
- python-version: "3.7"
pandas-version: "1.4.4"
- python-version: "3.7"
pandas-version: "1.5.2"
- python-version: "3.10"
pandas-version: "1.2.5"
- python-version: "3.10"
pandas-version: "1.3.5"
- python-version: "3.10"
Expand Down
7 changes: 2 additions & 5 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,8 @@ def lint(session):
"python,pandas",
[
(python, pandas)
for python in ("3.7", "3.8", "3.9", "3.10")
for pandas in ("1.2.5", "1.3.5", "1.4.4", "1.5.2")
if (python, pandas) != ("3.7", "1.4.4")
if (python, pandas) != ("3.7", "1.5.2")
if (python, pandas) != ("3.10", "1.2.5")
for python in ("3.8", "3.9", "3.10", "3.11")
for pandas in ("1.3.5", "1.4.4", "1.5.3")
if (python, pandas) != ("3.10", "1.3.5")
if (python, pandas) != ("3.10", "1.4.4")
],
Expand Down
5 changes: 2 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,14 @@ classifiers =
Topic :: Database
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.6
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11

[options]
packages = find:
python_requires = >=3.7,<3.11
python_requires = >=3.7,<3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally overlooked it, but it should be

python_requires = >=3.8,<3.12

install_requires =
urllib3~=1.26,>=1.21.1
Copy link
Member

@chezou chezou Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this urllib3 limitation was introduced many years ago when pip had limited capability to resolve version conflicts. #14

I think we are okay to remove the version constraints, i.e., ~=1.26,>=1.21.1, (with some manual tests) since pip can resolve to choose the right version of urllib3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chezou! I created ticket to track this! Kindly continue with the review 🙇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your consideration.

Considering the current pip capability, giving a strict upper version requires frequent release; otherwise, pytd triggers version conflicts too often. Maybe preventing major upgrades for pandas and numpy would be reasonable now.

presto-python-client>=0.6.0
Expand Down
Loading