Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib.metadata instead of pkg_resources since deprecated #136

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pytd/__init__.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import importlib.metadata
import logging

import pkg_resources

from .client import Client

__version__ = pkg_resources.get_distribution("pytd").version
__version__ = importlib.metadata.version("pytd")
logger = logging.getLogger(__name__)
logger.addHandler(logging.StreamHandler())
logger.setLevel(logging.INFO)
Expand Down
7 changes: 4 additions & 3 deletions pytd/query_engine.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import abc
import importlib.metadata
import logging
import os
from urllib.parse import urlparse

import pkg_resources
import prestodb
import tdclient

__version__ = pkg_resources.get_distribution("pytd").version
__version__ = importlib.metadata.version("pytd")

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -95,7 +95,8 @@ def execute(self, query, **kwargs):
cur = self.cursor(**kwargs)
self.executed = cur.execute(query)
rows = cur.fetchall()
# cur.description is None for CREATE and DROP statements in recent version of Trino
# cur.description is None for CREATE and DROP statements in recent version of
# Trino
columns = [desc[0] for desc in cur.description] if cur.description else None
return {"data": rows, "columns": columns}

Expand Down
Loading