Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update bindings #422

Merged
merged 1 commit into from
Sep 2, 2024
Merged

build: update bindings #422

merged 1 commit into from
Sep 2, 2024

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Sep 2, 2024

No description provided.

@amaanq amaanq force-pushed the update branch 4 times, most recently from 0c7dc77 to 20e7858 Compare September 2, 2024 09:54
@amaanq amaanq merged commit 28378e7 into master Sep 2, 2024
8 of 9 checks passed
@amaanq amaanq mentioned this pull request Sep 2, 2024
@amaanq
Copy link
Member Author

amaanq commented Sep 2, 2024

@eed3si9n I didn't know Max wasn't apart of the crate owners for the Rust package for this grammar - do you mind inviting him (maxbrunsfeld@gmail.com) or me (amaanq12@gmail.com) so we can turn the publishing action green? Now all that a maintainer here needs to do is tag a commit & push the tag and the CI job will publish each package across python/js/rust

@eed3si9n
Copy link
Collaborator

eed3si9n commented Sep 3, 2024

I'm pretty sure I did invite you both a while back, but let me invite again.

@eed3si9n eed3si9n deleted the update branch September 3, 2024 01:28
@eed3si9n
Copy link
Collaborator

eed3si9n commented Sep 3, 2024

Also was a reason this and a366c0d were merged without review and while the tests failed?
With tree-sitter-scala, first we land a PR, we run a GitHub Action to securely generate the C code, and then tag the release with the C code in the master branch.

eed3si9n added a commit to eed3si9n/tree-sitter-scala that referenced this pull request Sep 9, 2024
It seems like tree-sitter#422 was merged while it was failing on CI.

This reverts some of the changes.
@eed3si9n eed3si9n mentioned this pull request Sep 9, 2024
eed3si9n added a commit to eed3si9n/tree-sitter-scala that referenced this pull request Sep 10, 2024
It seems like tree-sitter#422 was merged while it was failing on CI.

This reverts some of the changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants