Fix type alias violation in scanner #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting the following error in windows-latest test on GH actions: Did I miss some steps to generate some files, or is this unrelated to my change? If it's the latter, is there an easy way for me to rerun the checks? Thank you! |
|
CI I think is broken and I've been trying to send a PR to fix it (#425). I'm guessing this is unrelated to your change. |
|
I see. I can wait for #425 to go in first. Thank you! |
yangchi
force-pushed
the
yang/type_alias
branch
from
5197292
to
b12abcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast from buffer which is char* to uint16_t* is a type alias violation.
If tree-sitter-scala is build with UBSAN enabled this is a runtime error.
This PR fixes it by replacing these cast + assignment with just plain old memcpy.