-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyproject.toml with hatch #156
base: master
Are you sure you want to change the base?
Conversation
use hatch environments add test_script to test plotting figures
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 97.11% 92.45% -4.66%
==========================================
Files 29 15 -14
Lines 1939 1127 -812
Branches 0 227 +227
==========================================
- Hits 1883 1042 -841
+ Misses 56 52 -4
- Partials 0 33 +33 ☔ View full report in Codecov by Sentry. |
I modified a bit the Github action so instead of calling hatch once to run all the tests, the workflow creates a matrix of python and seaborn versions (we could also add an OS matrix if needed, see https://github.com/platformdirs/platformdirs/ for the modifications to do). Github runs matrix jobs in parallel so the tests are substantially faster. |
I forgot to mention that python 3.7 is not tested (hatch was not working for me with this python version). It would be better to drop it, as it is EOL anyway. |
Modernize the building and testing framework:
To build:
hatch build
orpython -m build
To bump version:
hatch version minor
To test:
hatch run tests:run
To test with coverage:
hatch run tests:run-cov && hatch run coverage:run
To build and test docs:
hatch run docs:all
To run examples:
hatch run examples:run -- --plot_type=boxplot --data_type=df_with_group_and_hue
To test #155 I had to write the
test_script.py
file and it was very convenient to usehatch
environments for testing. So I thought I should actually make a PR about it :)