-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement webauthn extra origins & Raise KeyCloak version to 24.0.5 in acceptance tests #313
Implement webauthn extra origins & Raise KeyCloak version to 24.0.5 in acceptance tests #313
Conversation
There are now merge conflicts due to other PR getting merged. Also this needs to be bumped to new minimum version:
puppet-module-keycloak/manifests/init.pp Line 225 in a627fa4
|
If the latest version is 24.x it might be better to just bump the minimum version to 24.x since it looks like Keycloak only supports n-1. |
Actually, make 24.x the minimum as seems 25.0.0 is now released. |
Looks like 25.0.0 may break several things. I think it'd be fine to just upgrade this to 24.0.5 as default and only tested version and then do 25.0.0 separate which I can help with. |
Thanks, yeah looks like 25.0.0 has a few things which need changes in the module or at least in tests. |
I am working on 25.x support and so may not release this until I release the support for 25.x. There are some breaking changes to support 25.x that will also require a major version bump. |
No problem, i don't need these properties anyway - just implemented them to have all present in the module. |
#312 implements quiet a few properties on the realm resource.
The webauthn & webauthn passwordless extra origins property require at least KeyCloak 23.0.0 as it was added with that release.
This PR raises the minimum KeyCloak version used for acceptance testing and will add these properties.