PR: Better Filtering (Base 1) #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinda rough draft but it does fix that bug Fixes treymo#68
ImperialSquid
changed the title
|
Hey thank you and so sorry about my unresponsiveness. Life is hectic, but I'll make sure I get to the review this week! |
|
Absolutely no worries! Take your time! These are also both fairly big PRs in terms of reorganising the code so don't feel pressured to review them quickly or anything lol, the ones for filtering with notebooks IDs, tags and notes should all be much smaller lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just the base for future PRs hoping to overhaul how the plugin does filtering as described here
(Fyi, each feature will be a PR building from the last, so you can approve as we go, but I can still code while you're doing that)
It is also based on the merging of branch
feat/upgrade-plugin-and-apiMost of the PR is a massive refactor to split the logic of the plugin into separate files according to their functionality, since that should help with maintainability.
The other thing this PR does is fix issue #68 by moving the filtering step inside the loop for getting the linked notes.