PR: Better Filtering (Base 2) #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build off from #74 - Better Filtering (Base 1)
The PR moves around some of the filtering logic, so now it gets the notebooks to be filtered in one step before getting the notes, then passes in an array of
Notebooks, rather than passing in the raw names array and other filtering options.This way, constructing the notebook filter and using it are no longer mixed together in the same functions. It also now gets all notebooks once at the start (unlike the multiple times which might occur when getting linked notes), which is a minor optimisation.
(This should hopefully be the last PR before I start implementing new features like filtering by notebook ID, tags, etc)