Decred support #28
Closed
Decred support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decred testnet coin type
peterzen
force-pushed
the
decred-integration
branch
from
257eebf
to
0316f61
Compare
| @@ -81,7 +81,10 @@ enum MessageType { | |||
| MessageType_DebugLinkMemoryRead = 110 [(wire_debug_in) = true]; | |||
| MessageType_DebugLinkMemory = 111 [(wire_debug_out) = true]; | |||
| MessageType_DebugLinkMemoryWrite = 112 [(wire_debug_in) = true]; | |||
| MessageType_DebugLinkFlashErase = 113 [(wire_debug_in) = true]; | |||
| MessageType_DebugLinkFlashErase = 113 [(wire_debug_in) = true]; | |||
| "default_fee_b": { | ||
| "Normal": 10 | ||
| }, | ||
| "dust_limit": 546, |
| "default_fee_b": { | ||
| "Normal": 10 | ||
| }, | ||
| "dust_limit": 546, |
| * @next Success | ||
| * @next Failure | ||
| */ | ||
| message DecredLoadDevice { |
There was a problem hiding this comment.
Did you need a new message or could you have added it as an enum in the existing message?
| "hash_genesis_block": "298e5cc3d985bfe7f81dc135f360abe089edd4396b86d2de66b0cef42b21d980", | ||
| "xpub_magic": "043587d1", | ||
| "xprv_magic": "04358397", | ||
| "bip44": 11, |
There was a problem hiding this comment.
Testnet should use 1. 11 is registered to another coin.
|
Apologies, pushed to this branch by mistake – I'll delete the PR and resubmit once complete. |
|
@peterzen You don't have to delete the PR. You can force push to the branch and the PR will be updated |
prusnak
force-pushed
the
master
branch
3 times, most recently
from
9777329
to
2eb9c7e
Compare
prusnak
force-pushed
the
master
branch
2 times, most recently
from
b416c20
to
5f7a1a7
Compare
|
Any update? |
|
Is this a dead project :( |
|
@edwilli no. It's on a different pull request and being reviewed for next firmware, I believe. trezor/trezor-mcu#274 |
matejcik
pushed a commit
that referenced
this pull request
Aug 13, 2019
- placeOrder, cancelOrder, transfer messages - cli support - unit and device tests
matejcik
pushed a commit
that referenced
this pull request
Nov 19, 2021
- placeOrder, cancelOrder, transfer messages - cli support - unit and device tests
matejcik
pushed a commit
that referenced
this pull request
Nov 22, 2021
- placeOrder, cancelOrder, transfer messages - cli support - unit and device tests
trezor-ci
pushed a commit
to vdovhanych/trezor-common
that referenced
this pull request
Jan 26, 2022
- placeOrder, cancelOrder, transfer messages - cli support - unit and device tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Decred params with SegWit flag, resolved conflict