-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clarify how to break out of build_tx loops #4092
Conversation
If you enter empty string, the condition above (if not x) will be true and perform break instead of continue, no? |
I think that was the original intent, indeed. But it does not seem to work for me. If you enter empty string, I added the |
related: #4144 |
python/docs/EXAMPLES.rst
Outdated
@@ -72,7 +72,7 @@ After authenticating, open the "Send" tab, fill-out all details, then open the " | |||
|
|||
.. code:: | |||
|
|||
$ python3 tools/build_tx.py | trezorctl btc sign-tx - | |||
$ python3 python/tools/build_tx.py | trezorctl btc sign-tx - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "source distribution" is what you get when you download trezor...zip
from pypi
so the paths in python/
subdir are relative to that. please revert here & below.
(the change is appropriate in tools/snippets
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. 7407bd7
it seems that the fix proposed in #4191 is simpler, why not use that? |
That also works, but there are 2 loops I got stuck in, and this PR addresses both. But sure, I could change |
2e546b1
to
7407bd7
Compare
7407bd7
to
6d69e25
Compare
[no changelog]
6d69e25
to
21fa52a
Compare
Fixes #4191