test(suite-web): add a test for t3t1 multishare backup #14268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quickly tested right now with (hopefully) new trezor-user-env and got this. 
|
Right, Shamir works currently only for |
|
Shamir for |
|
Can @HajekOndrej take over this now? |
|
he has lots of stuff to do I gues, but yes, he surely can :] We maybe don't really need this test anymore (urgently), I wanted to prepare a test-driven repro for #13777 which might have been already fixed anyway |
HajekOndrej
force-pushed
the
test-multishare-backup
branch
4 times, most recently
from
56f9431
to
bcbb0c0
Compare
tomasklim
reviewed
Oct 14, 2024
packages/suite-web/e2e/tests/backup/t3t1-create-addtional-share.test.ts
Outdated
Show resolved
Hide resolved
HajekOndrej
force-pushed
the
test-multishare-backup
branch
from
bcbb0c0
to
b288459
Compare
tomasklim
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so I was about to investigate #13777 which requires many manual steps and since there are no tests for t3t1 I decided that this is a great opportunity to add one.
The problem is that I couldn't make it work. I smell some troubles with
readAndConfirmShamirMnemonicEmu.I hope @grdddj will help 🙏