Pr drone can support flight test patch #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Sep 19, 2024
Src/DroneCAN/DroneCAN.c
Outdated
| *(uint16_t *)p->ptr = req.value.integer_value; | ||
| if (p->eeprom_index != 0) { | ||
| if (p->eeprom_index == 26) { | ||
| eepromBuffer[26] = (uint8_t)((*(uint16_t *)p->ptr - 20) / 40); |
There was a problem hiding this comment.
it would be good to have a comment explaining this :-)
There was a problem hiding this comment.
change it to readable define EEPROM_MOTOR_KV_INDEX, btw, the code is tab and space mix a little bit mess to correct the format
Huibean
force-pushed
the
pr-DroneCAN-support-flight-test-patch
branch
8 times, most recently
from
e80bd43
to
7e7a13c
Compare
|
|
4.add HSE support and VIMDRONES_NANO_CAN_L431 target |
tridge
force-pushed
the
pr-DroneCAN-support
branch
2 times, most recently
from
c59731c
to
db3a145
Compare
tridge
force-pushed
the
pr-DroneCAN-support-flight-test-patch
branch
from
be21c16
to
1f9a17c
Compare
|
i've rebased this |
tridge
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch for first flight test
1.current value convert fix
2.add motor kv param