Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: fix additionalFiles, uncaught exceptions, and improve errors #1048

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Apr 21, 2024

Changelog:

  • Fix additionalFiles that aren't decendants
  • Stop swallowing uncaught exceptions in prod
  • Improve warnings and errors, fail early on critical warnings
  • New arg to --save-logs even for successful builds

Additional files that aren't decendants of the project dir were previously saved outside of the build context. They are now properly included like this:

  • ../foo/bar saved at ./foo/bar
  • ../../bar/baz saved at ./bar/baz

This means that a prisma schema in a monorepo can now be referenced like this:

trigger.config.ts

{
  additionalFiles: ["../../packages/database/prisma/schema.prisma"]
}

package.json

{
  "scripts": {
    "postinstall": "prisma generate --schema=./packages/database/prisma/schema.prisma"
  }
}

Copy link

changeset-bot bot commented Apr 21, 2024

🦋 Changeset detected

Latest commit: b37f0f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nicktrn nicktrn changed the title V3/fix additional files v3: fix additionalFiles, uncaught exceptions, and improve errors Apr 21, 2024
@nicktrn nicktrn merged commit ed2a26c into main Apr 21, 2024
4 checks passed
@nicktrn nicktrn deleted the v3/fix-additional-files branch April 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant