v3: Various fixes for Next.js projects and projects that use v2 and v3 together #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7dae81f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ericallam
force-pushed
the
v3/fix-trigger-dirs
branch
from
462cc09
to
540455e
Compare
ericallam
force-pushed
the
v3/fix-trigger-dirs
branch
from
540455e
to
e942438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nextand also was treating a v2 trigger Next.js App Router route as a v3 trigger dir.mswto throw a ModuleNotFound error in Next.js@trigger.dev/core/v3and moved them into separate exports (e.g.@trigger.dev/core/v3/zodNamespace. From now on only stuff needed in the SDK should be exported from@trigger.dev/core/v3.TaskandTaskOptionstype, which fixes theExported variable 'helloWorldTask' has or is using name 'Task' from external module "<project>/node_modules/@trigger.dev/sdk/dist/v3/index" but cannot be namederror