Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix shape and reformat free tensor handling in the input byte size check #7444

Merged
merged 6 commits into from
Jul 27, 2024

Conversation

pskiran1
Copy link
Contributor

@pskiran1 pskiran1 commented Jul 14, 2024

What does the PR do?

  • Updated the README with instructions on using the new is_non_linear_format_io flag in the model configuration.
  • Added a test plan to the L0_model_config job to evaluate the is_non_linear_format_io flag.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

common: triton-inference-server/common#125
core: triton-inference-server/core#380
tensorrt_backend: triton-inference-server/tensorrt_backend#97

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 16565646

Caveats:

Background

triton-inference-server/core#364

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@pskiran1 pskiran1 changed the title Fix shape and reformat free tensor handling in the input byte size check docs: Fix shape and reformat free tensor handling in the input byte size check Jul 14, 2024
@pskiran1 pskiran1 marked this pull request as ready for review July 14, 2024 17:40
@pskiran1 pskiran1 added the PR: docs Documentation only changes label Jul 14, 2024
@pskiran1 pskiran1 added PR: ci Changes to our CI configuration files and scripts and removed PR: docs Documentation only changes labels Jul 15, 2024
@pskiran1 pskiran1 changed the title docs: Fix shape and reformat free tensor handling in the input byte size check ci: Fix shape and reformat free tensor handling in the input byte size check Jul 15, 2024
GuanLuo
GuanLuo previously approved these changes Jul 18, 2024
Copy link
Contributor

@GuanLuo GuanLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the shape / reformat-free test cases in the input byte size validation test?

@pskiran1
Copy link
Contributor Author

Can you add the shape / reformat-free test cases in the input byte size validation test?

Added new test cases (shape / reformat-free input byte size validation) to L0_input_validationand L0_trt_reformat_free.

@pskiran1 pskiran1 merged commit 334f81f into main Jul 27, 2024
3 checks passed
@pskiran1 pskiran1 deleted the spolisetty_dlis_6805 branch July 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ci Changes to our CI configuration files and scripts
Development

Successfully merging this pull request may close these issues.

3 participants