test: Test model_metrics config and document histogram buckets override #7752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinggeh
added
PR: docs
This was referenced Oct 29, 2024
yinggeh
changed the title
yinggeh
changed the title
GuanLuo
reviewed
Oct 29, 2024
yinggeh
force-pushed
the
yinggeh-DLIS-7457-per-model-metric-config
branch
from
64a5623
to
65c736e
Compare
yinggeh
force-pushed
the
yinggeh-DLIS-7457-per-model-metric-config
branch
from
65c736e
to
4af437e
Compare
rmccorm4
reviewed
Nov 1, 2024
rmccorm4
reviewed
Nov 1, 2024
GuanLuo
reviewed
Nov 5, 2024
|
|
||
| SERVER_ARGS="--model-repository=${MODELDIR} --model-control-mode=explicit --load-model=${decoupled_model} --metrics-config histogram_latencies=true --log-verbose=1" | ||
| run_and_check_server | ||
| export OVERRIDE_BUCKETS="-1,0,1,2.5,+Inf" |
There was a problem hiding this comment.
You are still hard-coding the buckets value..
There was a problem hiding this comment.
Hard coded here because it is non-trivial work to convert a double in string to the displayed bucket "le" value in Prometheus.
0.00 -> le="0"
1.0100 -> le="1.01"
100 -> le="100"
000 -> le="0"
1. -> le="1"
qa/L0_model_config/model_metrics/valid_config_with_warn/unknown_metric_family/expected
Outdated
Show resolved
Hide resolved
… yinggeh-DLIS-7457-per-model-metric-config
rmccorm4
reviewed
Nov 5, 2024
rmccorm4
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Tests new model_metrics message in pbtxt. Add example to override histogram buckets per-family.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/core#405
triton-inference-server/common#126
Where should the reviewer start?
Test plan:
L0_metrics
20106057
Caveats:
Background
Default histogram buckets does not satisfy all use cases.