Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(freeradius): Update container to remove TCCR #17566

Closed
wants to merge 1 commit into from
Closed

fix(freeradius): Update container to remove TCCR #17566

wants to merge 1 commit into from

Conversation

StevenMcElligott
Copy link
Collaborator

@StevenMcElligott StevenMcElligott commented Jan 28, 2024 •
edited
Loading

Description

Someone this one didn't get changed lol

⚒️ Fixes #17528

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@StevenMcElligott StevenMcElligott marked this pull request as draft January 28, 2024 03:56
@StevenMcElligott
Copy link
Collaborator Author

Weird, I dunno the app so I was just changing the image, someone else might have to look into

@xstar97
Copy link
Contributor

xstar97 commented Jan 28, 2024

We actually still mirror this; in the apps dir

@StevenMcElligott
Copy link
Collaborator Author

Ah cool, guess we have a custom container for it still, I'm just trying to clear out the simple issues

@StevenMcElligott
Copy link
Collaborator Author

This isn't a fix since this was built using a custom container on the old repo

@StevenMcElligott StevenMcElligott deleted the freeradius-newrepo branch January 30, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrivatePuffin PrivatePuffin Awaiting requested review from PrivatePuffin PrivatePuffin is a code owner

@alfi0812 alfi0812 Awaiting requested review from alfi0812 alfi0812 will be requested when the pull request is marked ready for review alfi0812 is a code owner

@kqmaverick kqmaverick Awaiting requested review from kqmaverick kqmaverick will be requested when the pull request is marked ready for review kqmaverick is a code owner

@Heavybullets8 Heavybullets8 Awaiting requested review from Heavybullets8 Heavybullets8 will be requested when the pull request is marked ready for review Heavybullets8 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Freeradius failing to pull image
2 participants
@StevenMcElligott @xstar97