Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change docker base image for aMule #23543

Closed
2 tasks done
madmalkav opened this issue Jun 19, 2024 · 1 comment · Fixed by #28676
Closed
2 tasks done

Change docker base image for aMule #23543

madmalkav opened this issue Jun 19, 2024 · 1 comment · Fixed by #28676
Labels
enhancement New feature or request

Comments

@madmalkav
Copy link

Is your feature request related to a problem?

aMule base image used doesn't seems to be maintained often.

Describe the solution you'd like

I would like to suggest to use https://github.com/ngosang/docker-amule instead.

Describe alternatives you've considered

I haven't found any other docker image that seems better maintained than the one I linked.

Additional context

No response

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.
@madmalkav madmalkav added the enhancement New feature or request label Jun 19, 2024
@xstar97 xstar97 mentioned this issue Nov 1, 2024
Merged
13 tasks
alfi0812 pushed a commit that referenced this issue Nov 1, 2024
@xstar97
feat(amule) update amule to a new image and made changes to the value…
9ac55b4 
…s.yaml (#28676)

**Description**
Updated the image to a semVer image and updated the config to reflect
the changes.
⚒️ Fixes  #23543

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [X] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [X] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning
- [X] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@madmalkav @truecharts-admin