Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(penpot): cleanup penpot and add to incubator #17061

Closed
wants to merge 17 commits into from
Closed

Conversation

PrivatePuffin
Copy link
Member

@PrivatePuffin PrivatePuffin commented Jan 9, 2024

Description
This cleans-up penpot and adds to incubator.
I aimed to keep it KISS, by not moving it to multi-pod right-away.

⚒️ Fixes #16581

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@PrivatePuffin
Copy link
Member Author

@xstar97 in case you're wondering this is the current error:

2m2s        Warning   Failed                        pod/penpot-132hpmoavn-59c7f5b748-d7xnv                        spec.containers{penpot-132hpmoavn}                         kubelet, k3d-k3s-default-server-0                                                                    Error: secret "penpot-132hpmoavn-penpot-secrets" not found                                                                                                                                                                                      3m26s        8       penpot-132hpmoavn-59c7f5b748-d7xnv.17b6542c982305d5

Copy link

📝 Linting results:

✖️ Linting [charts/incubator/penpot]: Failed - Took 1 seconds
Total Charts Linted: 1
Total Charts Passed: 0
Total Charts Failed: 1

❌ Linting: Failed - Took 1 seconds
🖱️ Open [Lint Charts and Verify Dependencies] job
👀 Expand [Run Chart Linting] step to view the results

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ xstar97
❌ Kjeld Schouten


Kjeld Schouten seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alfi0812
Copy link
Collaborator

Close because of inactivity.

@alfi0812 alfi0812 closed this Jul 24, 2024
@PrivatePuffin PrivatePuffin deleted the penpot branch October 18, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

penpot
4 participants