Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI detector: regex matches invalid characters, greedily overlaps with other URIs #3686

Open
rgmz opened this issue Nov 27, 2024 · 0 comments · May be fixed by #3815
Open

URI detector: regex matches invalid characters, greedily overlaps with other URIs #3686

rgmz opened this issue Nov 27, 2024 · 0 comments · May be fixed by #3815
Assignees
Labels

Comments

@rgmz
Copy link
Contributor

rgmz commented Nov 27, 2024

Example

<p><a href="http://username:password@127.0.0.1">http://username:password@127.0.0.1</a></p>

This matches http://username:password@127.0.0.1">http://username:password@127.0.0.1 and not http://username:password@127.0.0.1 twice.

Found unverified result 🐷🔑❓
Verification issue: lookup 127.0.0.1">http: no such host
Detector Type: URI
Decoder Type: PLAIN
Raw result: http://username:password@127.0.0.1">http://username:password@127.0.0.1
Commit: 95a76587eea5863480ff23e34bd415d8ec0d6b2a
File: test/mattermost.txt
Line: 151
Link: https://github.com/mattermost/commonmark.js/blob/95a76587eea5863480ff23e34bd415d8ec0d6b2a/test/mattermost.txt#L151
@rgmz rgmz added the bug label Nov 27, 2024
@kashifkhan0771 kashifkhan0771 linked a pull request Dec 23, 2024 that will close this issue
2 tasks
@kashifkhan0771 kashifkhan0771 linked a pull request Dec 23, 2024 that will close this issue
2 tasks
@kashifkhan0771 kashifkhan0771 self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants