Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedEndpointSetter test failing #3819

Open
rgmz opened this issue Dec 26, 2024 · 0 comments
Open

EmbeddedEndpointSetter test failing #3819

rgmz opened this issue Dec 26, 2024 · 0 comments

Comments

@rgmz
Copy link
Contributor

rgmz commented Dec 26, 2024

@mcastorina This test is failing; not sure why.

Edit: it looks like #3308 changed the logic in a way that subtly broke the test.

--- FAIL: TestEmbeddedEndpointSetter (0.00s)
    endpoint_customizer_test.go:12: 
                Error Trace:    /tmp/trufflehog/pkg/detectors/endpoint_customizer_test.go:12
                Error:          Not equal: 
                                expected: []string{"baz"}
                                actual  : []string(nil)
                                
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1,4 +1,2 @@
                                -([]string) (len=1) {
                                - (string) (len=3) "baz"
                                -}
                                +([]string) <nil>
                                 
                Test:           TestEmbeddedEndpointSetter
FAIL

assert.Equal(t, []string{"baz"}, s.Endpoints("baz"))

Originally posted by @rgmz in #3773 (comment)


Unclear whether the feature is broken or the test is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant