-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually run unit tests #3773
base: main
Are you sure you want to change the base?
Actually run unit tests #3773
Conversation
f7da488
to
98bc643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the missing tags @rgmz
98bc643
to
9da3dd9
Compare
@mcastorina This test is failing; not sure why. Edit: it looks like #3308 changed the logic in a way that subtly broke the test.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were the modified tests changed to make them pass?
) | ||
|
||
func TestAzure_Pattern(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this deleted on purpose?
Yes.
Yes, the tests didn't actually work. More coverage is added in #3722. |
9da3dd9
to
5ba24e1
Compare
This is currently the only failing test. Is it something that can be fixed in another PR?
|
b0eea95
to
8817b1e
Compare
8817b1e
to
c3e845e
Compare
Description:
Unit tests don't get run outside of a few circumstances because
pkg/detectors
is filtered.Also, several integration tests were missing build tags.
Checklist:
make test-community
)?make lint
this requires golangci-lint)?