Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ScrapingBee detector #3820

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update ScrapingBee detector #3820

merged 1 commit into from
Jan 7, 2025

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Dec 29, 2024

Description:

This is a revival of #1923.

Changes:

  • Update keywords
  • Update structure to deduplicate matches + verify logic
  • Add unit tests

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner December 29, 2024 19:06
@rgmz rgmz mentioned this pull request Dec 29, 2024
Merged
2 tasks
abmussani
abmussani approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@abmussani abmussani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rgmz for updating this <3

@rgmz rgmz force-pushed the fix/scrapingbee-detector branch from 784a18f to 316316e Compare December 31, 2024 15:20
@abmussani
Copy link
Contributor

@rgmz Can you fix the linter issue so we can merge it ? Thank you

@rgmz rgmz force-pushed the fix/scrapingbee-detector branch from 316316e to 3b0bfd3 Compare January 7, 2025 14:23
@rgmz
Copy link
Contributor Author

rgmz commented Jan 7, 2025

@rgmz Can you fix the linter issue so we can merge it ? Thank you

Done.

@zricethezav
Copy link
Collaborator

failing test unrelated to changes

@zricethezav zricethezav merged commit 6a4856c into trufflesecurity:main Jan 7, 2025
12 of 13 checks passed
@rgmz rgmz deleted the fix/scrapingbee-detector branch January 7, 2025 17:12
@blsaccess blsaccess mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifkhan0771 kashifkhan0771 kashifkhan0771 approved these changes

@abmussani abmussani abmussani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgmz @abmussani @zricethezav @kashifkhan0771