Support for Customize Endpoint in Gitlab Analyzer #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, Gitlab Analyzer analyze for cloud endpoint
https://gitlab.combut detector supports custom endpoint which breaks the analyzer if credentials belongs to on-prem or gitlab dedicated service. This PR adds support for providing the host information to analyzer and also use default cloud endpoint if customize host is not provided.Analyzer Test:
Detector test (only for v2 as I do not have valid credential for v1 ):
Checklist:
make test-community)?make lintthis requires golangci-lint)?